wuchong commented on code in PR #2537:
URL: https://github.com/apache/fluss/pull/2537#discussion_r2751312437
##########
fluss-lake/fluss-lake-lance/src/test/java/org/apache/fluss/lake/lance/tiering/LanceTieringITCase.java:
##########
@@ -94,8 +97,46 @@ void testTiering() throws Exception {
t1.getDatabaseName(),
t1.getTableName());
- // check data in lance
- checkDataInLanceAppendOnlyTable(config, flussRows);
+ // check data in lance, including array columns
+ checkDataInLanceAppendOnlyTableWithArrays(config, flussRows);
+ checkSnapshotPropertyInLance(config,
Collections.singletonMap(t1Bucket, 30L));
+
+ jobClient.cancel().get();
+ }
+
+ @Test
+ void testTieringWithFloatArrayForVectorEmbeddings() throws Exception {
Review Comment:
Why not merge this test into `testTiering()` by simply adding multiple
array-type columns?
Having a separate test case doesn’t seem to add significant value and
unnecessarily increases overall test execution time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
