luoyuxia commented on code in PR #230:
URL: https://github.com/apache/fluss-rust/pull/230#discussion_r2759080236
##########
bindings/cpp/CMakeLists.txt:
##########
@@ -88,12 +90,16 @@ target_sources(fluss_cpp PRIVATE ${RUST_HEADER_FILE})
target_include_directories(fluss_cpp PUBLIC ${CPP_INCLUDE_DIR})
target_link_libraries(fluss_cpp PUBLIC ${RUST_LIB})
target_link_libraries(fluss_cpp PRIVATE ${CMAKE_DL_LIBS} Threads::Threads)
+target_link_libraries(fluss_cpp PRIVATE Arrow::arrow_shared)
Review Comment:
Seem paimon-cpp make the downstream projects to provide arrow
https://alibaba.github.io/paimon-cpp/build_system.html
I have no experience on it. Let's change it PUBLIC to see what'll happen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
