wuchong commented on code in PR #2326:
URL: https://github.com/apache/fluss/pull/2326#discussion_r2783031180
##########
fluss-lake/fluss-lake-paimon/src/test/java/org/apache/fluss/lake/paimon/LakeEnabledTableCreateITCase.java:
##########
@@ -994,6 +971,29 @@ void testEnableLakeTableWithLegacySystemTimestampColumn()
throws Exception {
.isTrue();
}
+ @Test
+ void testCreatePaimonDvTableWithNonStringPartitionColumn() throws
Exception {
+ TablePath tablePath = TablePath.of(DATABASE, "invalid_dv_table");
+ TableDescriptor tableDescriptor =
+ TableDescriptor.builder()
+ .schema(
+ Schema.newBuilder()
+ .column("c1", DataTypes.INT())
+ .column("c2", DataTypes.STRING())
+ .column("c3", DataTypes.INT())
+ .primaryKey("c1", "c3")
+ .build())
+ .property(ConfigOptions.TABLE_DATALAKE_ENABLED, true)
+ .property("paimon.deletion-vectors.enabled", "true")
+ .partitionedBy("c3")
+ .build();
+
+ assertThatThrownBy(() -> admin.createTable(tablePath, tableDescriptor,
false).get())
+ .rootCause()
+ .hasMessageContaining(
+ "Only support String type as partitioned key when
'deletion-vectors.enabled' is set to true for paimon, found 'c3' is not String
type.");
Review Comment:
Could you please add an **upgrade note** highlighting this behavior change?
In the new version, for partitioned tables where the partition key columns
are **not of string type**, enabling `table.datalake.enabled` with Paimon
format is **no longer allowed** when `paimon.deletion-vectors.enabled` is set
to `true`. This combination will result in a configuration error. This will be
supported in the near future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
