luoyuxia commented on code in PR #294:
URL: https://github.com/apache/fluss-rust/pull/294#discussion_r2786142978
##########
bindings/cpp/src/table.cpp:
##########
@@ -129,25 +129,54 @@ TableScan Table::NewScan() { return TableScan(table_); }
// TableScan implementation
TableScan::TableScan(ffi::Table* table) noexcept : table_(table) {}
-TableScan& TableScan::Project(std::vector<size_t> column_indices) {
+TableScan& TableScan::ProjectByIndex(std::vector<size_t> column_indices) {
Review Comment:
I feel like the method naming is inconsistent across different clients.
I think the rule maybe:
- java client is a gold reference
- if the language support method overloading, follow java naming.
- If not, we may may need to consider the interface naming. In this case,
rust side, I'll like to change `project` to other symmetrical method.
I think it's important since it's public interface and we need to give user
consistent experience when using different clients.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
