fresh-borzoni commented on code in PR #296:
URL: https://github.com/apache/fluss-rust/pull/296#discussion_r2788450788
##########
bindings/cpp/src/lib.rs:
##########
@@ -1084,79 +1007,24 @@ impl Table {
self.has_pk
}
- fn new_upsert_writer(&self) -> Result<*mut UpsertWriter, String> {
- let _enter = RUNTIME.enter();
-
- let fluss_table = fcore::client::FlussTable::new(
- &self.connection,
- self.metadata.clone(),
- self.table_info.clone(),
- );
-
- let table_upsert = fluss_table
- .new_upsert()
- .map_err(|e| format!("Failed to create upsert: {e}"))?;
-
- let writer = table_upsert
- .create_writer()
- .map_err(|e| format!("Failed to create upsert writer: {e}"))?;
-
- Ok(Box::into_raw(Box::new(UpsertWriter {
- inner: writer,
- table_info: self.table_info.clone(),
- })))
- }
-
- fn new_upsert_writer_with_column_names(
- &self,
- column_names: Vec<String>,
- ) -> Result<*mut UpsertWriter, String> {
- let _enter = RUNTIME.enter();
-
- let fluss_table = fcore::client::FlussTable::new(
- &self.connection,
- self.metadata.clone(),
- self.table_info.clone(),
- );
-
- let table_upsert = fluss_table
- .new_upsert()
- .map_err(|e| format!("Failed to create upsert: {e}"))?;
-
- let col_refs: Vec<&str> = column_names.iter().map(|s|
s.as_str()).collect();
- let table_upsert = table_upsert
- .partial_update_with_column_names(&col_refs)
- .map_err(|e| format!("Failed to set partial update columns:
{e}"))?;
-
- let writer = table_upsert
- .create_writer()
- .map_err(|e| format!("Failed to create upsert writer: {e}"))?;
-
- Ok(Box::into_raw(Box::new(UpsertWriter {
- inner: writer,
- table_info: self.table_info.clone(),
- })))
- }
-
- fn new_upsert_writer_with_column_indices(
+ fn create_upsert_writer(
&self,
column_indices: Vec<usize>,
) -> Result<*mut UpsertWriter, String> {
let _enter = RUNTIME.enter();
- let fluss_table = fcore::client::FlussTable::new(
- &self.connection,
- self.metadata.clone(),
- self.table_info.clone(),
- );
-
- let table_upsert = fluss_table
+ let table_upsert = self
+ .fluss_table()
.new_upsert()
.map_err(|e| format!("Failed to create upsert: {e}"))?;
- let table_upsert = table_upsert
- .partial_update(Some(column_indices))
- .map_err(|e| format!("Failed to set partial update columns:
{e}"))?;
+ let table_upsert = if column_indices.is_empty() {
+ table_upsert
+ } else {
+ table_upsert
+ .partial_update(Some(column_indices))
+ .map_err(|e| format!("Failed to set partial update columns:
{e}"))?
+ };
Review Comment:
minor, but 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
