loserwang1024 commented on code in PR #2647:
URL: https://github.com/apache/fluss/pull/2647#discussion_r2797574640
##########
fluss-common/src/main/java/org/apache/fluss/record/LogRecordReadContext.java:
##########
@@ -286,6 +286,11 @@ public ProjectedRow getOutputProjectedRow(int schemaId) {
public void close() {
vectorSchemaRootMap.values().forEach(VectorSchemaRoot::close);
if (bufferAllocator != null) {
+ // Force-release any remaining allocated memory in case some
buffers were not tracked by
+ // vectorSchemaRootMap,
+ // for example temporary buffers left behind when an OOM occurs
during decompression
+ // (see https://github.com/apache/fluss/issues/2646).
+ bufferAllocator.releaseBytes(bufferAllocator.getAllocatedMemory());
Review Comment:
@platinumhamburg , I modified this PR and add a patched version of Arrow's
{@code VectorLoader} to fix this problem. Detail see VectorLoaderTest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
