Copilot commented on code in PR #2672:
URL: https://github.com/apache/fluss/pull/2672#discussion_r2802009785
##########
website/community/how-to-release/creating-a-fluss-release.mdx:
##########
@@ -195,30 +180,44 @@ Additionally, for the upgrade notes page of the version
currently being released
Commit the documentation changes, and push to the official repository.
```bash
-$ git commit -m "[docs] Create upgrade notes for $NEXT_SHORT_VERSION" .
+$ git commit -m "[docs] Create upgrade notes for $SHORT_NEXT_VERSION" .
$ git push origin main
```
**(3) Add version item in fluss-versions.json**
-Next, add a new version item for the current release version in the
`website/fluss-versions.json` file on the `main` branch. The new version item
should have the following fields and values (releasing `0.8.0` as an example):
+Next, add a new version item for the next release version in the
`website/fluss-versions.json` file on the `main` branch. The new version item
should have the following fields and values (current releasing `0.9.0`, next
release `0.10.0` as an example):
```json
{
- "versionName": "version-0.8",
- "fullVersion": "0.8.0-incubating",
- "shortVersion": "0.8",
- "dockerVersion": "0.8.0-incubating-rc1",
+ "versionName": "next",
+ "fullVersion": "0.10-SNAPSHOT",
+ "shortVersion": "0.10",
+ "dockerVersion": "0.10-SNAPSHOT",
+ "paimonVersion": "1.3.1",
+ "paimonVersionShort": "1.3",
"released": false
}
```
-Additionally, update the `fullVersion`, `shortVersion`, and `dockerVersion`
fields for the `next` version entry to reflect the next release version.
+Additionally, update the `fullVersion`, `shortVersion`, and `dockerVersion`
fields for the `current` version entry to reflect the current release version.
+
+```json
+{
+ "versionName": "version-0.9",
+ "fullVersion": "0.8.0-incubating",
+ "shortVersion": "0.8",
+ "dockerVersion": "0.8.0-incubating",
Review Comment:
Inconsistent version numbers in the example JSON. The versionName is
"version-0.9" but the fullVersion and shortVersion fields reference
"0.8.0-incubating" and "0.8". These should be consistent with "0.9" to match
the versionName.
```suggestion
"fullVersion": "0.9.0-incubating",
"shortVersion": "0.9",
"dockerVersion": "0.9.0-incubating",
```
##########
website/community/how-to-release/creating-a-fluss-release.mdx:
##########
@@ -195,30 +180,44 @@ Additionally, for the upgrade notes page of the version
currently being released
Commit the documentation changes, and push to the official repository.
```bash
-$ git commit -m "[docs] Create upgrade notes for $NEXT_SHORT_VERSION" .
+$ git commit -m "[docs] Create upgrade notes for $SHORT_NEXT_VERSION" .
$ git push origin main
```
**(3) Add version item in fluss-versions.json**
-Next, add a new version item for the current release version in the
`website/fluss-versions.json` file on the `main` branch. The new version item
should have the following fields and values (releasing `0.8.0` as an example):
+Next, add a new version item for the next release version in the
`website/fluss-versions.json` file on the `main` branch. The new version item
should have the following fields and values (current releasing `0.9.0`, next
release `0.10.0` as an example):
```json
{
- "versionName": "version-0.8",
- "fullVersion": "0.8.0-incubating",
- "shortVersion": "0.8",
- "dockerVersion": "0.8.0-incubating-rc1",
+ "versionName": "next",
+ "fullVersion": "0.10-SNAPSHOT",
+ "shortVersion": "0.10",
+ "dockerVersion": "0.10-SNAPSHOT",
+ "paimonVersion": "1.3.1",
+ "paimonVersionShort": "1.3",
"released": false
}
```
-Additionally, update the `fullVersion`, `shortVersion`, and `dockerVersion`
fields for the `next` version entry to reflect the next release version.
+Additionally, update the `fullVersion`, `shortVersion`, and `dockerVersion`
fields for the `current` version entry to reflect the current release version.
+
+```json
+{
+ "versionName": "version-0.9",
+ "fullVersion": "0.8.0-incubating",
+ "shortVersion": "0.8",
+ "dockerVersion": "0.8.0-incubating",
Review Comment:
The dockerVersion should be "0.9.0-incubating" to match the versionName
"version-0.9" instead of "0.8.0-incubating".
```suggestion
"dockerVersion": "0.9.0-incubating",
```
##########
website/community/how-to-release/creating-a-fluss-release.mdx:
##########
@@ -195,30 +180,44 @@ Additionally, for the upgrade notes page of the version
currently being released
Commit the documentation changes, and push to the official repository.
```bash
-$ git commit -m "[docs] Create upgrade notes for $NEXT_SHORT_VERSION" .
+$ git commit -m "[docs] Create upgrade notes for $SHORT_NEXT_VERSION" .
$ git push origin main
```
**(3) Add version item in fluss-versions.json**
-Next, add a new version item for the current release version in the
`website/fluss-versions.json` file on the `main` branch. The new version item
should have the following fields and values (releasing `0.8.0` as an example):
+Next, add a new version item for the next release version in the
`website/fluss-versions.json` file on the `main` branch. The new version item
should have the following fields and values (current releasing `0.9.0`, next
release `0.10.0` as an example):
```json
{
- "versionName": "version-0.8",
- "fullVersion": "0.8.0-incubating",
- "shortVersion": "0.8",
- "dockerVersion": "0.8.0-incubating-rc1",
+ "versionName": "next",
+ "fullVersion": "0.10-SNAPSHOT",
+ "shortVersion": "0.10",
+ "dockerVersion": "0.10-SNAPSHOT",
+ "paimonVersion": "1.3.1",
+ "paimonVersionShort": "1.3",
"released": false
}
```
-Additionally, update the `fullVersion`, `shortVersion`, and `dockerVersion`
fields for the `next` version entry to reflect the next release version.
+Additionally, update the `fullVersion`, `shortVersion`, and `dockerVersion`
fields for the `current` version entry to reflect the current release version.
+
+```json
+{
+ "versionName": "version-0.9",
+ "fullVersion": "0.8.0-incubating",
+ "shortVersion": "0.8",
+ "dockerVersion": "0.8.0-incubating",
+ "paimonVersion": "1.3.1",
+ "paimonVersionShort": "1.3",
+ "released": false
+ }
+```
Commit the documentation changes, and push to the official repository.
```bash
-$ git commit -m "[docs] Add version item for $RELEASE_VERSION in
fluss-versions.json
+$ git commit -m "[docs] Add version item for $RELEASE_VERSION"
fluss-versions.json
Review Comment:
The commit message references "$RELEASE_VERSION" but according to the
instructions above (line 189), this step adds a version item for the next
release version, not the current release version. The commit message should
reference the next version variable instead, or be clarified to say "Add
version item for next release after $RELEASE_VERSION".
```suggestion
$ git commit -m "[docs] Add version item for next release after
$RELEASE_VERSION" fluss-versions.json
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
