leekeiabstraction commented on code in PR #304:
URL: https://github.com/apache/fluss-rust/pull/304#discussion_r2803140143
##########
crates/fluss/src/row/datum.rs:
##########
@@ -493,7 +494,21 @@ impl Datum<'_> {
Datum::Float32(v) => append_value_to_arrow!(Float32Builder,
v.into_inner()),
Datum::Float64(v) => append_value_to_arrow!(Float64Builder,
v.into_inner()),
Datum::String(v) => append_value_to_arrow!(StringBuilder,
v.as_ref()),
- Datum::Blob(v) => append_value_to_arrow!(BinaryBuilder,
v.as_ref()),
+ Datum::Blob(v) => {
+ append_value_to_arrow!(BinaryBuilder, v.as_ref());
+ if let Some(b) = builder
+ .as_any_mut()
+ .downcast_mut::<FixedSizeBinaryBuilder>()
+ {
+ return b.append_value(v.as_ref()).map_err(|e|
RowConvertError {
+ message: format!("Failed to append FixedSizeBinary:
{e}"),
Review Comment:
I've made it so that arrow error is surfaced instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
