niknegi commented on code in PR #310:
URL: https://github.com/apache/fluss-rust/pull/310#discussion_r2803311863
##########
crates/fluss/src/metadata/datatype.rs:
##########
@@ -1469,3 +1568,79 @@ fn test_timestamp_ltz_invalid_precision() {
.contains("Timestamp with local time zone precision must be
between 0 and 9")
);
}
+
+// ============================================================================
+// RowType projection tests
+// ============================================================================
+
+#[test]
+fn test_row_type_project_valid_indices() {
+ // Create a 3-column row type
+ let row_type = RowType::with_data_types_and_field_names(
+ vec![DataTypes::int(), DataTypes::string(), DataTypes::bigint()],
+ vec!["id", "name", "age"],
+ );
+
+ // Valid projection by indices: [0, 2]
+ let projected = row_type.project(&[0, 2]).unwrap();
+ assert_eq!(projected.fields().len(), 2);
+ assert_eq!(projected.fields()[0].name, "id");
+ assert_eq!(projected.fields()[1].name, "age");
+}
+
+#[test]
+fn test_row_type_project_with_field_names_valid() {
+ // Create a 3-column row type
+ let row_type = RowType::with_data_types_and_field_names(
+ vec![DataTypes::int(), DataTypes::string(), DataTypes::bigint()],
+ vec!["id", "name", "age"],
+ );
+
+ // Valid projection by names: ["id", "name"]
+ let projected = row_type
+ .project_with_field_names(&["id".to_string(), "name".to_string()])
+ .unwrap();
+ assert_eq!(projected.fields().len(), 2);
+ assert_eq!(projected.fields()[0].name, "id");
+ assert_eq!(projected.fields()[1].name, "name");
+}
+
+#[test]
+fn test_row_type_project_index_out_of_bounds() {
+ // Create a 3-column row type
+ let row_type = RowType::with_data_types_and_field_names(
+ vec![DataTypes::int(), DataTypes::string(), DataTypes::bigint()],
+ vec!["id", "name", "age"],
+ );
+
+ // Error: index out of bounds
+ let result = row_type.project(&[0, 5]);
+ assert!(result.is_err());
+ assert!(
+ result.unwrap_err().to_string().contains("invalid field position: 5")
+ );
+}
+
+#[test]
+fn test_row_type_project_with_field_names_nonexistent() {
+ // Create a 3-column row type
+ let row_type = RowType::with_data_types_and_field_names(
+ vec![DataTypes::int(), DataTypes::string(), DataTypes::bigint()],
+ vec!["id", "name", "age"],
+ );
+
+ // Error: non-existent field name
+ // Note: project_with_field_names filters out non-existent field names
using filter_map,
+ // so the result will be an empty row if all field names are non-existent
+ let projected = row_type
+ .project_with_field_names(&["nonexistent".to_string()])
+ .unwrap();
+ assert_eq!(projected.fields().len(), 0);
+
+ // Mixed existing and non-existing: only existing fields are projected
+ let projected = row_type
+ .project_with_field_names(&["id".to_string(),
"nonexistent".to_string()])
Review Comment:
Yes, checking it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
