morazow opened a new issue, #2698:
URL: https://github.com/apache/fluss/issues/2698

   ### Search before asking
   
   - [x] I searched in the [issues](https://github.com/apache/fluss/issues) and 
found nothing similar.
   
   
   ### Fluss version
   
   main (development)
   
   ### Please describe the bug 🐞
   
   When using special characters (e.g, `"`) in the SASL authentication 
mechanism, the client SASL parser fails.
   
   For example, a failing test for 
[`SaslClientAuthenticator`](https://github.com/apache/fluss/blob/main/fluss-common/src/main/java/org/apache/fluss/security/auth/sasl/authenticator/SaslClientAuthenticator.java):
   
   ```java
   @Test
   void testSpecialCharactersForPassword() throws Exception {
       final String specialPassword = "pa$$wo\\rd!@#%&\"";
       final Configuration clientConfig = new Configuration();
       clientConfig.setString("client.security.protocol", "sasl");
       clientConfig.setString("client.security.sasl.username", "admin");
       clientConfig.setString("client.security.sasl.password", specialPassword);
       testAuthentication(clientConfig, getDefaultServerConfig());
   }
   ```
   
   ### Solution
   
   The first solution would be to properly escape username and password on 
here: 
[`SaslClientAuthenticator.java#L64](https://github.com/apache/fluss/blob/main/fluss-common/src/main/java/org/apache/fluss/security/auth/sasl/authenticator/SaslClientAuthenticator.java#L64)
   
   In general it would be nice to have utility to escape special characters. 
   
   We should check for similar issues on the server side. The fix should 
introduce proper failing tests for special characters.
   
   ### Are you willing to submit a PR?
   
   - [x] I'm willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to