xx789633 commented on code in PR #2692:
URL: https://github.com/apache/fluss/pull/2692#discussion_r2828582237
##########
helm/templates/_helpers.tpl:
##########
@@ -63,4 +63,29 @@ Selector labels
{{- define "fluss.selectorLabels" -}}
app.kubernetes.io/name: {{ include "fluss.name" . }}
app.kubernetes.io/instance: {{ .Release.Name }}
-{{- end }}
\ No newline at end of file
+{{- end }}
+
+{{/*
+Image name
+*/}}
+{{- define "fluss.image" -}}
+{{- $image := printf "%s:%s" .Values.image.repository .Values.image.tag }}
Review Comment:
If a user omits image.tag or sets it to empty, this would produce an invalid
image reference like `apache/fluss:`. Maybe we need to add a fallback here.
##########
helm/templates/_helpers.tpl:
##########
@@ -63,4 +63,29 @@ Selector labels
{{- define "fluss.selectorLabels" -}}
app.kubernetes.io/name: {{ include "fluss.name" . }}
app.kubernetes.io/instance: {{ .Release.Name }}
-{{- end }}
\ No newline at end of file
+{{- end }}
+
+{{/*
+Image name
+*/}}
+{{- define "fluss.image" -}}
+{{- $image := printf "%s:%s" .Values.image.repository .Values.image.tag }}
Review Comment:
If a user provides a purely numeric tag (e.g. `tag: 1.0`), Helm may parse it
as a float, causing printf "%s" to output 1 instead of "1.0".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
