charlesdong1991 commented on code in PR #360:
URL: https://github.com/apache/fluss-rust/pull/360#discussion_r2843190413
##########
bindings/cpp/src/lib.rs:
##########
@@ -607,12 +608,17 @@ fn err_from_core_error(e: &fcore::error::Error) ->
ffi::FfiResult {
// Connection implementation
fn new_connection(config: &ffi::FfiConfig) -> Result<*mut Connection, String> {
+ let assigner_type = match config.writer_bucket_no_key_assigner.as_str() {
+ "round_robin" => fluss::config::NoKeyAssigner::RoundRobin,
+ _ => fluss::config::NoKeyAssigner::Sticky,
Review Comment:
ah, good catch! Rust, Java and Python will fail fast right now
will make a change!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
