luoyuxia commented on code in PR #375:
URL: https://github.com/apache/fluss-rust/pull/375#discussion_r2867390428
##########
bindings/cpp/test/test_utils.h:
##########
@@ -49,23 +49,46 @@
namespace fluss_test {
-static constexpr const char* kFlussVersion = "0.7.0";
+static constexpr const char* kFlussImage = "apache/fluss";
+static constexpr const char* kFlussVersion = "0.8.0-incubating";
static constexpr const char* kNetworkName = "fluss-cpp-test-network";
static constexpr const char* kZookeeperName = "zookeeper-cpp-test";
static constexpr const char* kCoordinatorName = "coordinator-server-cpp-test";
static constexpr const char* kTabletServerName = "tablet-server-cpp-test";
static constexpr int kCoordinatorPort = 9123;
static constexpr int kTabletServerPort = 9124;
+static constexpr int kPlainClientPort = 9223;
+static constexpr int kPlainClientTabletPort = 9224;
/// Execute a shell command and return its exit code.
-inline int RunCommand(const std::string& cmd) {
- return system(cmd.c_str());
+inline int RunCommand(const std::string& cmd) { return system(cmd.c_str()); }
Review Comment:
nit: maybe we can consider whether we can enable it to use rust code.
Duplicate code is error-prone and hard to maintain.
We can create a issue for it, let's do it in the future work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
