fresh-borzoni commented on code in PR #404:
URL: https://github.com/apache/fluss-rust/pull/404#discussion_r2868997578
##########
crates/fluss/src/client/write/accumulator.rs:
##########
@@ -391,10 +573,41 @@ impl RecordAccumulator {
break;
}
+ // Improvement: `continue` instead of `break` to skip
Review Comment:
We can backport it back to Fluss, it's from Kafka implementation, but in
fluss buckets are independent, so we can optimise it here
##########
crates/fluss/src/client/write/accumulator.rs:
##########
@@ -391,10 +573,41 @@ impl RecordAccumulator {
break;
}
+ // Improvement: `continue` instead of `break` to skip
Review Comment:
We can backport it back to Fluss Java, it's from Kafka implementation, but
in fluss buckets are independent, so we can optimise it here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
