affo commented on code in PR #2674:
URL: https://github.com/apache/fluss/pull/2674#discussion_r2871191374
##########
fluss-filesystems/fluss-fs-s3/src/main/java/org/apache/fluss/fs/s3/token/S3DelegationTokenProvider.java:
##########
@@ -70,31 +70,34 @@ public S3DelegationTokenProvider(String scheme,
Configuration conf) {
public ObtainedSecurityToken obtainSecurityToken() {
LOG.info("Obtaining session credentials token with access key: {}",
accessKey);
- AWSSecurityTokenService stsClient =
- AWSSecurityTokenServiceClientBuilder.standard()
- .withRegion(region)
- .withCredentials(
- new AWSStaticCredentialsProvider(
- new BasicAWSCredentials(accessKey,
secretKey)))
+ StsClient stsClient =
Review Comment:
@luoyuxia I plan to restructure this part of the code by addressing
https://github.com/apache/fluss/issues/2662 anyhow 🤝
The idea is to allow more flexible `AWSCredentialsProviders` to delegate
tokens to clients.
Would probably fix under some peculiar configuration?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
