fresh-borzoni commented on code in PR #399:
URL: https://github.com/apache/fluss-rust/pull/399#discussion_r2871657975
##########
crates/fluss/src/client/connection.rs:
##########
@@ -41,17 +41,23 @@ impl FlussConnection {
.map_err(|msg| Error::IllegalArgument { message: msg })?;
let timeout = Duration::from_millis(arg.connect_timeout_ms);
+ let request_timeout = Duration::from_millis(arg.request_timeout_ms);
let connections = if arg.is_sasl_enabled() {
Arc::new(
RpcClient::new()
.with_sasl(
arg.security_sasl_username.clone(),
arg.security_sasl_password.clone(),
)
- .with_timeout(timeout),
+ .with_timeout(timeout)
+ .with_request_timeout(request_timeout),
)
} else {
- Arc::new(RpcClient::new().with_timeout(timeout))
+ Arc::new(
+ RpcClient::new()
+ .with_timeout(timeout)
Review Comment:
shall we change the name here as well?
As we have two chained timeout builder methods now and `with_timeout` reads
ambigious
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
