fresh-borzoni commented on code in PR #411:
URL: https://github.com/apache/fluss-rust/pull/411#discussion_r2881003559
##########
crates/fluss/src/client/table/lookup.rs:
##########
@@ -20,13 +20,16 @@ use crate::client::metadata::Metadata;
use crate::client::table::partition_getter::PartitionGetter;
use crate::error::{Error, Result};
use crate::metadata::{PhysicalTablePath, RowType, TableBucket, TableInfo,
TablePath};
+use crate::record::ArrowRecordBatchInnerBuilder;
Review Comment:
Yes, I understand the trait needs to be in scope, my concern is that
ArrowRecordBatchInnerBuilder is an internal trait leaking into this module.
Could you add inherent methods on RowAppendRecordBatchBuilder that delegate
to the trait methods?
Then the trait stays internal and this module just calls builder.append() /
builder.build_arrow_record_batch() without the import.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
