toxicteddy00077 commented on code in PR #422:
URL: https://github.com/apache/fluss-rust/pull/422#discussion_r2881972772
##########
bindings/cpp/include/fluss.hpp:
##########
@@ -180,6 +180,18 @@ struct ErrorCode {
static constexpr int INVALID_ALTER_TABLE_EXCEPTION = 56;
/// Deletion operations are disabled on this table.
static constexpr int DELETION_DISABLED_EXCEPTION = 57;
+
+ /// Returns true if retrying the request may succeed. Similar toJava's
RetriableException hierarchy.
+ static constexpr bool IsRetriable(int32_t code) {
+ return code == NETWORK_EXCEPTION || code == NOT_LEADER_OR_FOLLOWER ||
Review Comment:
feedback much appreciated,I should checked the fluss source myself. I asked
an LLM to enumerate all the exceptions the extend `RetriableException`, but it
seems to have given for `ApiException` and others as well. My apologies.
Apart from this having looked at the source myself ,there were a few others
i think I should add, such as `CorruptMessageException` and
`SchemaNotExistException`. let me know since i think the rest are correct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
