charlesdong1991 commented on code in PR #407: URL: https://github.com/apache/fluss-rust/pull/407#discussion_r2889813566
########## crates/fluss/src/metrics.rs: ########## @@ -0,0 +1,229 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! Metric name constants and helpers for fluss-rust client instrumentation. +//! +//! Uses the [`metrics`] crate facade pattern: library code emits metrics via +//! `counter!`/`gauge!`/`histogram!` macros, and the application installs a +//! recorder (e.g. `metrics-exporter-prometheus`) to collect them. When no +//! recorder is installed, all metric calls are no-ops with zero overhead. + +use crate::rpc::ApiKey; + +// --------------------------------------------------------------------------- +// Label keys +// --------------------------------------------------------------------------- + +pub const LABEL_API_KEY: &str = "api_key"; + +// --------------------------------------------------------------------------- +// Connection / RPC metrics +// +// Java reference: ConnectionMetrics.java, ClientMetricGroup.java, MetricNames.java +// +// Note on bytes_received: Rust counts the response body length (after the Review Comment: i think you are right. Did a checking the Java side source code, they have ``` int responseSize = response.totalSize(); int frameLength = RESPONSE_HEADER_LENGTH + responseSize; ``` so total size is just the body, and excludes framing and header While in rust, `get_ref().len()` will return total length of `Vec` which ignores cursor position, so should be header+body. Will update, thanks! 👍 @fresh-borzoni -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
