fresh-borzoni commented on code in PR #417:
URL: https://github.com/apache/fluss-rust/pull/417#discussion_r2891425412
##########
crates/fluss/src/config.rs:
##########
@@ -143,6 +167,18 @@ impl std::fmt::Debug for Config {
"scanner_log_max_poll_records",
&self.scanner_log_max_poll_records,
)
+ .field(
+ "scanner_log_fetch_max_bytes",
+ &self.scanner_log_fetch_max_bytes,
+ )
+ .field(
+ "scanner_log_fetch_min_bytes",
+ &self.scanner_log_fetch_min_bytes,
+ )
+ .field(
Review Comment:
missing `scanner_log_fetch_max_bytes_for_bucket`
##########
crates/fluss/src/config.rs:
##########
@@ -95,11 +99,31 @@ pub struct Config {
#[arg(long, default_value_t = DEFAULT_MAX_POLL_RECORDS)]
pub scanner_log_max_poll_records: usize,
+ /// Maximum bytes per fetch response for LogScanner.
+ /// Default: 16777216 (16MB)
+ #[arg(long, default_value_t = DEFAULT_SCANNER_LOG_FETCH_MAX_BYTES)]
+ pub scanner_log_fetch_max_bytes: i32,
+
+ /// Minimum bytes to accumulate before returning a fetch response.
+ /// Default: 1
+ #[arg(long, default_value_t = DEFAULT_SCANNER_LOG_FETCH_MIN_BYTES)]
+ pub scanner_log_fetch_min_bytes: i32,
+
+ /// Maximum time the server may wait (ms) to satisfy min-bytes.
+ /// Default: 500
+ #[arg(long, default_value_t = DEFAULT_SCANNER_LOG_FETCH_WAIT_MAX_TIME_MS)]
+ pub scanner_log_fetch_wait_max_time_ms: i32,
+
/// The maximum time to wait for a batch to be completed in milliseconds.
/// Default: 100 (matching Java CLIENT_WRITER_BATCH_TIMEOUT)
#[arg(long, default_value_t = DEFAULT_WRITER_BATCH_TIMEOUT_MS)]
pub writer_batch_timeout_ms: i64,
+ /// Maximum bytes per fetch response **per bucket** for LogScanner.
+ /// Default: 1048576 (1MB) (or whatever DEFAULT_BUCKET_MAX_FETCH_BYTES is)
Review Comment:
let's remove 'or whatever ...' part, it's inconsistent
##########
crates/fluss/src/config.rs:
##########
@@ -95,6 +98,21 @@ pub struct Config {
#[arg(long, default_value_t = DEFAULT_MAX_POLL_RECORDS)]
pub scanner_log_max_poll_records: usize,
+ /// Maximum bytes per fetch response for LogScanner.
+ /// Default: 16777216 (16MB)
+ #[arg(long, default_value_t = DEFAULT_SCANNER_LOG_FETCH_MAX_BYTES)]
Review Comment:
Ty, ffi_converter.hpp wiring is still missing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
