fresh-borzoni commented on code in PR #430: URL: https://github.com/apache/fluss-rust/pull/430#discussion_r2900652600
########## crates/fluss/src/record/arrow.rs: ########## @@ -151,6 +151,7 @@ pub const NO_BATCH_SEQUENCE: i32 = -1; pub const BUILDER_DEFAULT_OFFSET: i64 = 0; +// TODO: Switch to byte-size-based is_full() like Java's ArrowWriter instead of a hard record cap. pub const DEFAULT_MAX_RECORD: i32 = 256; Review Comment: Java's 1024 is an initial capacity for a different batching strategy, there is a follow up with this strategy: https://github.com/apache/fluss-rust/issues/431 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
