fresh-borzoni commented on PR #437: URL: https://github.com/apache/fluss-rust/pull/437#issuecomment-4019192543
> @charlesdong1991 Ty for the PR, LGTM > > Q: have you experienced cpp integration tests failure? In practice, all processes would try quick check and fail and go to WaitForCluster() which checks all ports. So in order for tests to fail, one process should start docker and have coordinator port ready, when other processes are still on a fast check. As all the processes start quickly and go for 1s fast check - close to zero chances practically. > > But it's fine as correctness fix 👍 Ah, I see, that's a different thing, we have everything started, but tablet_server hasn't registered yet - yes, this is correct fix then for the actual very possible race condition in tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
