luoyuxia commented on code in PR #399:
URL: https://github.com/apache/fluss-rust/pull/399#discussion_r2934338334
##########
crates/fluss/src/rpc/server_connection.rs:
##########
@@ -301,9 +325,9 @@ where
match map.remove(&header.request_id) {
Some(active_request) => active_request,
_ => {
- log::warn!(
+ log::debug!(
Review Comment:
I agree this is a normal late-response race.
However, a request timeout still suggests some underlying issue or risk that
users should be aware of. Metrics would help, but logs are often more
immediately useful in practice.
Fluss's Java client logs this as warn. I'm not sure whether Kafka client
does the same for a similar case, but Kafka client may be a better reference if
we want to follow common client behavior.
So I’m slightly leaning toward keeping warn for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
