wuchong commented on code in PR #2827:
URL: https://github.com/apache/fluss/pull/2827#discussion_r2938590548
##########
fluss-client/src/main/java/org/apache/fluss/client/write/Sender.java:
##########
@@ -580,6 +580,21 @@ private Set<PhysicalTablePath> handleWriteBatchException(
// sequence has advanced beyond the sequence of the current batch.
// The only thing we can do is to return success to the user.
completeBatch(readyWriteBatch);
+ } else if (error.error() == Errors.OUT_OF_ORDER_SEQUENCE_EXCEPTION
Review Comment:
Could we move this condition block along with the `error.error() ==
Errors.DUPLICATE_SEQUENCE_EXCEPTION` check to precede the `if (canRetry(..))`
block? This adjustment would streamline the logic within `canRetry` by removing
the need to wrap `isAlreadyCommitted`. Consequently, the workflow in
`handleWriteBatchException` becomes clearer: first verify if this is a valid
completion, then attempt a retry if applicable, and finally fail if neither
condition is met. cc @swuferhong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
