charlesdong1991 commented on code in PR #446:
URL: https://github.com/apache/fluss-rust/pull/446#discussion_r2962787794
##########
crates/fluss/src/client/table/scanner.rs:
##########
@@ -266,6 +277,14 @@ struct LogScannerInner {
log_scanner_status: Arc<LogScannerStatus>,
log_fetcher: LogFetcher,
is_partitioned_table: bool,
+ arrow_schema: SchemaRef,
+ /// Serializes overlapping `poll` / `poll_batches` across clones sharing
this `Arc`.
+ ///
+ /// TODO: Consider an API that consumes
Review Comment:
it is cheap to clone for this record batch log scanner, but all clones will
share one Arc<LogScannerInner> , so two overlapping poll is not supported under
current usage model, i add a client-side guard with poll_session so overlapping
calls can fail fast.
Not sure what you think, i am happy to create a new issue and do a follow-up
on that, or if you prefer i can have a stricter API in this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
