leekeiabstraction commented on code in PR #2933:
URL: https://github.com/apache/fluss/pull/2933#discussion_r3003555800
##########
fluss-flink/fluss-flink-common/src/main/java/org/apache/fluss/flink/tiering/source/TieringSplitReader.java:
##########
@@ -436,6 +443,7 @@ private TableBucketWriteResult<WriteResult>
completeLakeWriter(
WriteResult writeResult = null;
if (lakeWriter != null) {
writeResult = lakeWriter.complete();
+ tieringMetrics.recordBytesWritten(lakeWriter.getBytesWritten());
Review Comment:
LanceLakeWriter currently does not implement getBytesWritten() and therefore
default implementation will return -1. Will this corrupt the metric for Lance
tiering?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
