Kaixuan-Duan opened a new pull request, #3264:
URL: https://github.com/apache/fluss/pull/3264

   ### Purpose
   
   Linked issue: close #2624 
   
   <!-- What is the purpose of the change -->
   
   ### Brief change log
   
   - Reorder `KvTabletSnapshotTarget#updateStateOnCommitSuccess` so the 
outward-visible updates happen first:
   1.assign `logOffsetOfLatestSnapshot`
   2.assign `snapshotSize`
   3.invoke `updateMinRetainOffset.accept(flushedLogOffset)`
   4.then (in `finally`) invoke 
`rocksIncrementalSnapshot.notifySnapshotComplete(snapshotId)`
   - The RocksDB bookkeeping call is wrapped in a `finally` block so the 
internal `uploadedSstFiles` cleanup is guaranteed even if an outward update 
throws in the future.
   
   ### Tests
   
   ./mvnw -pl fluss-server test 
-Dtest='KvTabletSnapshotTargetTest#testAddToSnapshotToStoreFail'
   
   ### API and Format
   
   No API or storage format change.
   
   ### Documentation
   
   No user-facing documentation change.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to