fresh-borzoni commented on code in PR #532:
URL: https://github.com/apache/fluss-rust/pull/532#discussion_r3210214702
##########
website/docs/user-guide/cpp/api-reference.md:
##########
@@ -21,7 +21,9 @@ Complete API reference for the Fluss C++ client.
| `writer_request_max_size` | `int32_t` | `10485760` (10 MB)
| Maximum request size in bytes
|
| `writer_acks` | `std::string` | `"all"`
| Acknowledgment setting (`"all"`, `"0"`, `"1"`, or `"-1"`)
|
| `writer_retries` | `int32_t` | `INT32_MAX`
| Number of retries on failure
|
-| `writer_batch_size` | `int32_t` | `2097152` (2 MB)
| Batch size for writes in bytes
|
+| `writer_batch_size` | `int32_t` | `2097152` (2 MB)
| Batch size for writes in bytes (also the upper bound when dynamic sizing is
enabled) |
Review Comment:
I would leave `writer_batch_size` as it is as it's consistent with java,
just renamed new key a bit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
