matrixsparse commented on code in PR #3296:
URL: https://github.com/apache/fluss/pull/3296#discussion_r3248526278
##########
fluss-flink/fluss-flink-common/src/main/java/org/apache/fluss/flink/source/enumerator/FlinkSourceEnumerator.java:
##########
@@ -377,9 +377,12 @@ private void startInBatchMode() {
p.getPartitionId(),
p.getPartitionName()))
.collect(Collectors.toList());
- splits =
this.initPartitionedSplits(partitions);
+ // Use log-only splits to avoid generating
mixed split
+ // types (HybridSnapshotLogSplit + LogSplit)
for
+ // primary-key tables, which is not supported.
+ splits =
this.initLogTablePartitionSplits(partitions);
Review Comment:
@matrixsparse Good catch! Updated `getLogSplit()` to use
`stoppingOffsetsInitializer.getBucketOffsets()` and pass the stopping offset to
the 4-parameter `LogSplit` constructor. PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
