fresh-borzoni commented on code in PR #3322:
URL: https://github.com/apache/fluss/pull/3322#discussion_r3251729094
##########
fluss-common/src/main/java/org/apache/fluss/utils/PartitionUtils.java:
##########
@@ -345,4 +348,28 @@ public static String convertValueOfType(Object value,
DataTypeRoot type) {
}
return stringPartitionKey;
}
+
+ /** Projects {@code tableInfo}'s row type down to its partition key
columns, in key order. */
+ public static RowType partitionRowType(TableInfo tableInfo) {
+ RowType schema = tableInfo.getRowType();
+ List<String> fieldNames = schema.getFieldNames();
+ int[] indexes =
+
tableInfo.getPartitionKeys().stream().mapToInt(fieldNames::indexOf).toArray();
+ return schema.project(indexes);
+ }
+
+ /**
+ * Builds a row of typed partition values by parsing each string with
{@link
+ * #parseValueOfType(String, DataTypeRoot)} for the column at that ordinal
in {@code
+ * partitionRowType}.
+ */
+ public static GenericRow toPartitionRow(
+ List<String> partitionValues, RowType partitionRowType) {
+ GenericRow row = new GenericRow(partitionValues.size());
+ for (int i = 0; i < partitionValues.size(); i++) {
+ DataTypeRoot type = partitionRowType.getTypeAt(i).getTypeRoot();
+ row.setField(i, parseValueOfType(partitionValues.get(i), type));
+ }
+ return row;
+ }
Review Comment:
it's not a good idea, as it will skip with this "doesn't match" idea
##########
fluss-common/src/main/java/org/apache/fluss/utils/PartitionUtils.java:
##########
@@ -345,4 +348,28 @@ public static String convertValueOfType(Object value,
DataTypeRoot type) {
}
return stringPartitionKey;
}
+
+ /** Projects {@code tableInfo}'s row type down to its partition key
columns, in key order. */
+ public static RowType partitionRowType(TableInfo tableInfo) {
+ RowType schema = tableInfo.getRowType();
+ List<String> fieldNames = schema.getFieldNames();
+ int[] indexes =
+
tableInfo.getPartitionKeys().stream().mapToInt(fieldNames::indexOf).toArray();
+ return schema.project(indexes);
+ }
+
+ /**
+ * Builds a row of typed partition values by parsing each string with
{@link
+ * #parseValueOfType(String, DataTypeRoot)} for the column at that ordinal
in {@code
+ * partitionRowType}.
+ */
+ public static GenericRow toPartitionRow(
+ List<String> partitionValues, RowType partitionRowType) {
+ GenericRow row = new GenericRow(partitionValues.size());
+ for (int i = 0; i < partitionValues.size(); i++) {
+ DataTypeRoot type = partitionRowType.getTypeAt(i).getTypeRoot();
+ row.setField(i, parseValueOfType(partitionValues.get(i), type));
+ }
+ return row;
+ }
Review Comment:
it's not a good idea, as it will skip with this "doesn't match" skip fallback
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
