XuQianJin-Stars opened a new pull request, #3329: URL: https://github.com/apache/fluss/pull/3329
The catch blocks in `getKvSnapshotMetadata()` and `getFileSystemSecurityToken()` were discarding the original exception cause, making it very difficult to diagnose root causes in production. Changes: - Pass the caught exception as the cause parameter to `SecurityTokenException` (which already supports it) - Add a `(String, Throwable)` constructor to `KvSnapshotNotExistException` and pass the caught exception as the cause This is consistent with all other exception re-throwing patterns in the codebase (e.g., `CoordinatorService`, `HadoopConfSerde`, `PaimonLakeCatalog`) which always preserve the original exception chain. ## Purpose Preserve exception cause for better debuggability in production. Same pattern as #3281 but for `RpcServiceBase`. ## Brief change log - Added `(String, Throwable)` constructor to `KvSnapshotNotExistException` - Passed original exception as cause in `RpcServiceBase#getKvSnapshotMetadata()` - Passed original exception as cause in `RpcServiceBase#getFileSystemSecurityToken()` ## Tests - No new tests needed. This change only preserves additional exception information that was previously discarded. Existing tests continue to pass. ## API and Format - Added a new public constructor to `KvSnapshotNotExistException`. This is a backwards-compatible addition. ## Documentation - No documentation changes needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
