luoyuxia commented on PR #3355: URL: https://github.com/apache/fluss/pull/3355#issuecomment-4496835684
> [Re: comment](https://github.com/apache/fluss/pull/3355#discussion_r3272468910) I agree the original approach in `snapshotState()` is hard to understand without sufficient context. I've reworked the fix to use the `checkpointTriggeredBefore` flag in `generateHybridLakeFlussSplits()` instead. While the restore-awareness logic still requires some thought, this approach keeps all the complexity contained within a single method rather than spreading it across `snapshotState()`. Additionally, I changed `startInStreamModeForNonPartitionedTable` to call `generateHybridLakeFlussSplits()` synchronously, consistent with the partitioned-table path in `start()`. This ensures lake split initialization always completes before any checkpoint can be triggered, which is a prerequisite for the `checkpointTriggeredBefore` guard to work correctly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
