lilei1128 opened a new pull request, #3367:
URL: https://github.com/apache/fluss/pull/3367
<!--
*Thank you very much for contributing to Fluss - we are happy that you want
to help us improve Fluss. To help the community review your contribution in the
best possible way, please go through the checklist below, which will get the
contribution into a shape in which it can be best reviewed.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [GitHub
issue](https://github.com/apache/fluss/issues). Exceptions are made for typos
in JavaDoc or documentation files, which need no issue.
- Name the pull request in the format "[component] Title of the pull
request", where *[component]* should be replaced by the name of the component
being changed. Typically, this corresponds to the component label assigned to
the issue (e.g., [kv], [log], [client], [flink]). Skip *[component]* if you are
unsure about which is the best component.
- Fill out the template below to describe the changes contributed by the
pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean
verify` passes.
- Each pull request should address only one issue, not mix up code from
multiple issues.
- **Generative AI disclosure:** Indicate whether generative AI tools were
used in authoring this PR. If yes, specify the tool below.
- [ ] No generative AI tools used
- [ ] Yes (please specify the tool below)
**(The sections below can be removed for hotfixes or typos)**
-->
<!--
Generated-by: [Tool Name and Version] following [the
guidelines](https://github.com/apache/fluss/blob/main/AGENTS.md)
-->
### Purpose
<!-- Linking this pull request to the issue -->
Linked issue: close #xxx
<!-- What is the purpose of the change -->
When partitions are continuously created and dropped, physical table path
entries in RecordAccumulator.writeBatches and Cluster.partitionsIdByPath
were never removed, causing unbounded memory growth and CPU waste from
iterating over stale entries in ready() and drain() hot loops.
### Brief change log
<!-- Please describe the changes made in this pull request and explain how
they address the issue -->
Fix 1 (RecordAccumulator): introduce markPathsAsStale() and
removeStalePathIfEmpty() with a dedicated staleLock so that the
check-then-remove is atomic with respect to concurrent append() calls.
New appends to stale paths are rejected immediately.
Fix 2 (MetadataUtils): during partial metadata updates, remove stale
partition entries for any table whose partition list was refreshed, so
that dropped partitions no longer linger in partitionsIdByPath.
Fix 3 (Sender): call cleanupStaleWriteBatches() on every sendWriteData()
cycle to mark paths absent from the cluster as stale and remove them once
their deques are fully drained.
### Tests
<!-- List UT and IT cases to verify this change -->
- RecordAccumulatorTest.testMarkAndRemoveStalePathAfterDrain: verifies
that append() is rejected after markPathsAsStale(), and that
removeStalePathIfEmpty() succeeds once the deque is drained.
- RecordAccumulatorTest.testRemoveStalePathReturnsFalseWhenDequeNonEmpty:
verifies that removeStalePathIfEmpty() returns false and preserves the
path when pending batches remain.
- SenderTest.testSenderCleansUpStaleWriteBatchesAfterMetadataUpdate:
verifies end-to-end that runOnce() removes a stale path from
writeBatches after the cluster no longer contains it and its deque
has been drained.
### API and Format
<!-- Does this change affect API or storage format -->
### Documentation
<!-- Does this change introduce a new feature -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
