nicolazar opened a new pull request, #566:
URL: https://github.com/apache/fluss-rust/pull/566
<!--
*Thank you very much for contributing to Fluss - we are happy that you want
to help us improve Fluss. To help the community review your contribution in the
best possible way, please go through the checklist below, which will get the
contribution into a shape in which it can be best reviewed.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [GitHub
issue](https://github.com/apache/fluss-rust/issues). Exceptions are made for
typos in JavaDoc or documentation files, which need no issue.
- Name the pull request in the format "[component] Title of the pull
request", where *[component]* should be replaced by the name of the component
being changed. Typically, this corresponds to the component label assigned to
the issue (e.g., [kv], [log], [client], [flink]). Skip *[component]* if you are
unsure about which is the best component.
- Fill out the template below to describe the changes contributed by the
pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean
verify` passes.
- Each pull request should address only one issue, not mix up code from
multiple issues.
**(The sections below can be removed for hotfixes or typos)**
-->
### Purpose
<!-- Linking this pull request to the issue -->
Linked issue: part of #463. This PR will be followed by separate PRs for the
scanner tuning and security/SASL + connect timeout options.
<!-- What is the purpose of the change -->
### Brief change log
This PR extends the Elixir bindings with new config options for writer
tuning, such as: writer acks, retries, request max size, idempotence, buffer
memory / wait timeout, max inflight requests per bucket, bucket assigner enum.
We first extend the NifConfig on the rust side to expose the new options,
then we add them to `Fluss.Config`, with the corresponding setters. The
upstream defaults are preserved if fields are not set, but callers may set
overrides per field.
Validation continues to be handled by `FlussConnection::new`
([`crates/fluss/src/client/connection.rs:40-48`](https://github.com/apache/fluss-rust/blob/main/crates/fluss/src/client/connection.rs#L40-L48))
which already calls `validate_writer` before any TCP I/O.
<!-- Please describe the changes made in this pull request and explain how
they address the issue -->
### Tests
Tests for the config setters are added in the new `test/config_tests.exs`:
- `new/1` defaults — all non-`bootstrap_servers` fields default to `nil`.
- One per-setter test for each of the 8 new setters.
- `set_writer_bucket_no_key_assigner/2`: happy path (`:sticky`) and guard
failure (`assert_raise FunctionClauseError` for unsupported atoms).
- Chained-setters test using `|>`.
<!-- List UT and IT cases to verify this change -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
