slfan1989 commented on PR #564: URL: https://github.com/apache/fluss-rust/pull/564#issuecomment-4554500916
> @slfan1989 Ty for the PR, LGTM overall, minor comment > > nit: these three wait_for_* loops (+ wait_for_cluster_ready_with_sasl) are the same poll-until-timeout skeleton copy-pasted, differing only in the probe. Could pull out a small poll_until(timeout, interval, || probe) helper - basically the Rust version of Java's CommonTestUtils.waitUtil/waitValue. Not blocking, just a thought since we're here. Thanks for the suggestion! Updated. I factored out the shared poll-until-timeout skeleton into a small `poll_until` helper and reused it in the table/partition readiness helpers as well as `wait_for_cluster_ready_with_sasl`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
