gyang94 opened a new pull request, #3391:
URL: https://github.com/apache/fluss/pull/3391
<!--
*Thank you very much for contributing to Fluss - we are happy that you want
to help us improve Fluss. To help the community review your contribution in the
best possible way, please go through the checklist below, which will get the
contribution into a shape in which it can be best reviewed.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [GitHub
issue](https://github.com/apache/fluss/issues). Exceptions are made for typos
in JavaDoc or documentation files, which need no issue.
- Name the pull request in the format "[component] Title of the pull
request", where *[component]* should be replaced by the name of the component
being changed. Typically, this corresponds to the component label assigned to
the issue (e.g., [kv], [log], [client], [flink]). Skip *[component]* if you are
unsure about which is the best component.
- Fill out the template below to describe the changes contributed by the
pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean
verify` passes.
- Each pull request should address only one issue, not mix up code from
multiple issues.
- **Generative AI disclosure:** Indicate whether generative AI tools were
used in authoring this PR. If yes, specify the tool below.
- [ ] No generative AI tools used
- [ ] Yes (please specify the tool below)
**(The sections below can be removed for hotfixes or typos)**
-->
<!--
Generated-by: [Tool Name and Version] following [the
guidelines](https://github.com/apache/fluss/blob/main/AGENTS.md)
-->
### Purpose
<!-- Linking this pull request to the issue -->
Linked issue: close #3357
<!-- What is the purpose of the change -->
### Brief change log
### Summary
When a `stopReplica` RPC fails due to transient network issues or a
TabletServer crash, the Coordinator has no reliable retry mechanism. This
causes replicas to get stuck and table deletion to never complete, resulting in
the `tableCount` metric never decreasing.
This PR introduces a **per-TabletServer sender thread model** (aligned with
Kafka's `ControllerChannelManager` / `RequestSendThread`) and a new
`ReplicaDeletionIneligible` state. These changes provide robust retry and
pause/resume semantics for replica deletion.
### Changes
#### Core: Per-TS Sender Thread (`ControlRequestSendThread`)
- **Dedicated Sender Thread:** Each TabletServer gets a dedicated sender
thread with a FIFO queue.
- **New Replica State:** Introduced a state for replicas whose deletion
cannot proceed (e.g., TS offline or returned a business error).
- **Resume Logic:** `TableManager.resumeDeletions()` implements 3-step logic:
1. Complete if all replicas succeeded.
2. Retry previously-ineligible replicas on alive TSes.
3. Re-fire eligible tables.
- **Auto-Resume on Reconnect:** `processNewTabletServer()` clears ineligible
marks and triggers `resumeDeletions()`, so paused deletions automatically
resume when a TS reconnects.
- **Handle Dead TS:** `processDeadTabletServer()` transitions in-flight
deletion replicas to `ineligible`.
#### Config
- `coordinator.request.retry.backoff`: Backoff between retries (default:
`100ms`).
- `coordinator.request.timeout`: RPC timeout per attempt (default: `30s`).
### ️ What was removed
- `retryDeleteAndSuccessDeleteReplicas()`: The old
"retry-N-then-force-success" mechanism.
- `failDeleteNumbers` tracking and `DELETE_TRY_TIMES` constant.
- Direct RPC calls from `CoordinatorRequestBatch` (replaced by queue-based
dispatch).
### Tests
<!-- List UT and IT cases to verify this change -->
### API and Format
<!-- Does this change affect API or storage format -->
### Documentation
<!-- Does this change introduce a new feature -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
