nicolazar commented on code in PR #574:
URL: https://github.com/apache/fluss-rust/pull/574#discussion_r3319228240
##########
bindings/elixir/lib/fluss/config.ex:
##########
@@ -74,6 +90,44 @@ defmodule Fluss.Config do
def set_bootstrap_servers(%__MODULE__{} = config, servers) when
is_binary(servers),
do: %{config | bootstrap_servers: servers}
+ @spec set_remote_file_download_thread_num(t(), non_neg_integer()) :: t()
+ def set_remote_file_download_thread_num(%__MODULE__{} = config, threads)
+ when is_integer(threads),
Review Comment:
@fresh-borzoni - I can do that, but in my opinion might be better to have a
separate PR (and issue) where we add dialyzer and fix all the warnings that
would appear. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
