loserwang1024 commented on code in PR #2747:
URL: https://github.com/apache/fluss/pull/2747#discussion_r3322849427
##########
fluss-client/src/main/java/org/apache/fluss/client/write/RecordAccumulator.java:
##########
@@ -720,6 +729,28 @@ private List<ReadyWriteBatch>
drainBatchesForOneNode(Cluster cluster, Integer no
continue;
}
+ if (tableBucket.getTableId() != first.tableId()) {
+ LOG.warn(
+ "Table {} has been dropped and re-created with a
new table ID. Old ID: {}, New ID: {}. "
+ + "Aborting pending batches for the old
table instance.",
+ physicalTablePath,
+ first.tableId(),
+ tableBucket.getTableId());
+ TableNotExistException reason =
+ new TableNotExistException(
+ String.format(
+ "Table '%s' has been dropped and
re-created with a new table ID (old: %d, new: %d). "
+ + "Further writes to the
old table instance cannot proceed. "
+ + "Please recreate the
writer with the new table metadata.",
+ physicalTablePath,
+ first.tableId(),
+ tableBucket.getTableId()),
+ null,
+ true);
+ abortBatch(reason, deque.pollFirst());
Review Comment:
get it! learn a lot from your review. "Invoking an alien method with a lock
held is asking for liveness trouble."
And I have modified it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
