loserwang1024 commented on code in PR #3390:
URL: https://github.com/apache/fluss/pull/3390#discussion_r3345662300
##########
fluss-client/src/main/java/org/apache/fluss/client/admin/FlussAdmin.java:
##########
@@ -139,13 +143,33 @@ public class FlussAdmin implements Admin {
private final AdminReadOnlyGateway readOnlyGateway;
private final MetadataUpdater metadataUpdater;
+ /**
+ * Single-thread executor that runs the metadata-refresh callback for
{@link
+ * RetryableGatewayClientProxy}.
+ */
+ private final ExecutorService refreshExecutor =
+ Executors.newFixedThreadPool(
+ 1, new
ExecutorThreadFactory("fluss-admin-metadata-refresh"));
+
public FlussAdmin(RpcClient client, MetadataUpdater metadataUpdater) {
- this.gateway =
+ AdminGateway rawGateway =
GatewayClientProxy.createGatewayProxy(
metadataUpdater::getCoordinatorServer, client,
AdminGateway.class);
- this.readOnlyGateway =
+ AdminGateway rawReadOnlyGateway =
GatewayClientProxy.createGatewayProxy(
metadataUpdater::getRandomTabletServer, client,
AdminGateway.class);
+ this.gateway =
+ RetryableGatewayClientProxy.createRetryableGatewayProxy(
+ rawGateway,
+ metadataUpdater::refreshClusterUntilAvailable,
Review Comment:
agree with you, in this PR, only focus on read only gateway and remove
coordinator gateway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
