nicolazar opened a new pull request, #597:
URL: https://github.com/apache/fluss-rust/pull/597
<!--
*Thank you very much for contributing to Fluss - we are happy that you want
to help us improve Fluss. To help the community review your contribution in the
best possible way, please go through the checklist below, which will get the
contribution into a shape in which it can be best reviewed.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [GitHub
issue](https://github.com/apache/fluss-rust/issues). Exceptions are made for
typos in JavaDoc or documentation files, which need no issue.
- Name the pull request in the format "[component] Title of the pull
request", where *[component]* should be replaced by the name of the component
being changed. Typically, this corresponds to the component label assigned to
the issue (e.g., [kv], [log], [client], [flink]). Skip *[component]* if you are
unsure about which is the best component.
- Fill out the template below to describe the changes contributed by the
pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean
verify` passes.
- Each pull request should address only one issue, not mix up code from
multiple issues.
**(The sections below can be removed for hotfixes or typos)**
-->
### Purpose
<!-- Linking this pull request to the issue -->
Linked issue: close #587
<!-- What is the purpose of the change -->
### Brief change log
This PR allows callers to set a database `comment` and `custom_properties`
when creating a database, via an optional `Fluss.DatabaseDescriptor`:
```elixir
descriptor =
Fluss.DatabaseDescriptor.new()
|> Fluss.DatabaseDescriptor.comment("App data")
|> Fluss.DatabaseDescriptor.put_custom_property("owner", "team-x")
:ok = Fluss.Admin.create_database(admin, "my_db", descriptor)
```
Previously `admin_create_database` hard-coded the descriptor to None, so the
only way to observe a descriptor was to read one back via `get_database_info/2`
(#586). This closes that gap on the write side.
We now change the `create_database` function to accept a descriptor as the
third positional argument, before `ignore_if_exists`.
<!-- Please describe the changes made in this pull request and explain how
they address the issue -->
### Tests
<!-- List UT and IT cases to verify this change -->
Added unit tests for the builder helpers (happy paths, overwrites,
cross-field preservation, guard/validation failures) and integration tests for
`create_database/3` with a descriptor (comment-only, properties-only,
struct-directly), asserting the values round-trip through `get_database_info/2`.
Additionally, strengthened the existing `get_database_info/2` test to assert
descriptor values rather than just shape.
### API and Format
The signature of admin `create_database/3` function has been changed:
previously it meant `create_database(admin, name, ignore_if_exists)`. It now
means `create_database(admin, name, descriptor)`. Callers that passed
`ignore_if_exists` positionally as the third argument must move it to the
fourth. The three in-repo callers have been updated.
<!-- Does this change affect API or storage format -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
