Copilot commented on code in PR #3358:
URL: https://github.com/apache/fluss/pull/3358#discussion_r3353257839
##########
fluss-common/src/main/java/org/apache/fluss/config/FlussConfigUtils.java:
##########
@@ -54,7 +56,7 @@ public class FlussConfigUtils {
}
public static boolean isTableStorageConfig(String key) {
- return key.startsWith(TABLE_PREFIX);
+ return TABLE_OPTIONS.containsKey(key);
}
Review Comment:
`isTableStorageConfig` now returns `TABLE_OPTIONS.containsKey(key)`, which
makes it equivalent to “recognized table option”. This breaks the distinction
used in `TableDescriptorValidation` and other callers: unknown `table.*` keys
will no longer be treated as (unrecognized) table options, and the “older
cluster doesn’t support this property” error path becomes unreachable. It also
changes behavior in places like `CoordinatorService`/Flink conversions by
reclassifying unknown `table.*` options as custom properties.
##########
fluss-common/src/main/java/org/apache/fluss/config/TableConfig.java:
##########
@@ -53,6 +53,11 @@ public TableConfig(Configuration config) {
this.config = config;
}
+ /** Gets the log segment file size of the table. */
+ public MemorySize getLogSegmentSize() {
+ return config.get(ConfigOptions.LOG_SEGMENT_FILE_SIZE);
+ }
Review Comment:
The class-level Javadoc says this helper is for "table.*" properties, but
`getLogSegmentSize()` reads `log.segment.file-size` (a non-"table.*" key). This
is easy to misunderstand for API consumers; please update the Javadoc to
reflect that some runtime options may be configurable per-table even when not
prefixed with `table.`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
