VladBanar opened a new pull request, #3444:
URL: https://github.com/apache/fluss/pull/3444
<!--
*Thank you very much for contributing to Fluss - we are happy that you want
to help us improve Fluss. To help the community review your contribution in the
best possible way, please go through the checklist below, which will get the
contribution into a shape in which it can be best reviewed.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [GitHub
issue](https://github.com/apache/fluss/issues). Exceptions are made for typos
in JavaDoc or documentation files, which need no issue.
- Name the pull request in the format "[component] Title of the pull
request", where *[component]* should be replaced by the name of the component
being changed. Typically, this corresponds to the component label assigned to
the issue (e.g., [kv], [log], [client], [flink]). Skip *[component]* if you are
unsure about which is the best component.
- Fill out the template below to describe the changes contributed by the
pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean
verify` passes.
- Each pull request should address only one issue, not mix up code from
multiple issues.
- **Generative AI disclosure:** Indicate whether generative AI tools were
used in authoring this PR. If yes, specify the tool below.
- [ ] No generative AI tools used
- [+] Yes (please specify the tool below)
**(The sections below can be removed for hotfixes or typos)**
-->
<!--
Generated-by: [Copilot(Claude Haiku 4.5)] following [the
guidelines](https://github.com/apache/fluss/blob/main/AGENTS.md)
-->
### Purpose
<!-- Linking this pull request to the issue -->
Linked issue: close [3439](https://github.com/apache/fluss/issues/3439)
<!-- What is the purpose of the change -->
Currently, POJO field names must exactly match Fluss table column names.
This creates rigid naming constraints that conflict with Java naming
conventions (camelCase) and database naming conventions (snake_case).
### Brief change log
1. Created @ColumnName Annotation
Example: @ColumnName("user_id") on a field named userId
2. Modified PojoType.java
Updated discoverAllInstanceFields() to check for @ColumnName annotations
When @ColumnName is present, uses the annotation value as the property key
instead of the field name
Maintains backward compatibility: fields without annotation use original
field names
Properties map is now keyed by column names (mapped or original)
3. Converter Integration
PojoToRowConverter and RowToPojoConverter automatically work with the
updated property mapping
No changes needed in converters—they query properties by column name, which
now respects@ColumnName mappings
<!-- Please describe the changes made in this pull request and explain how
they address the issue -->
### Tests
Added new test PojoTypeTest:testColumnNameAnnotation
<!-- List UT and IT cases to verify this change -->
### API and Format
No
<!-- Does this change affect API or storage format -->
### Documentation
<!-- Does this change introduce a new feature -->
Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]