charlesdong1991 commented on PR #610: URL: https://github.com/apache/fluss-rust/pull/610#issuecomment-4646587953
> with the proposed changes, what happens if i) method signatures doesn't match and II) assertion fails? assertion failures and method signatures mismatches will be caught at run time, to catch signature drift statically (including unexcercised ones), we can use .pyi drift testing... i also add assertions explicitly... wdyt? @leekeiabstraction > also shall we wire stubtest to test .pyi drift? yeah, we can do it, nice idea! there are 2 stub issues that are fixed in this PR, and wiring it to pass cleanly needs a bit more work as there are quite some diffs (a bit more than 100)... i can create a focused follow-up pr then if you are fine with that @fresh-borzoni -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
