charlesdong1991 commented on code in PR #609:
URL: https://github.com/apache/fluss-rust/pull/609#discussion_r3375795468
##########
crates/fluss/src/client/write/sender.rs:
##########
@@ -371,8 +376,15 @@ impl Sender {
}
};
- // let's put in back into records_by_bucket
- // since response handle will use it.
+ // Record attempted-send per-batch metrics after
+ // `build_write_request` (so `estimated_size_in_bytes` and
+ // `record_count` reflect the final serialized batch), before the
+ // actual request round-trip. Retries therefore contribute one
+ // sample per send attempt.
+ self.record_request_batch_metrics(&request_batches);
Review Comment:
ok, let's then match java behaviour for now, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
