Copilot commented on code in PR #3453:
URL: https://github.com/apache/fluss/pull/3453#discussion_r3376892177
##########
fluss-server/src/main/java/org/apache/fluss/server/coordinator/AutoPartitionManager.java:
##########
@@ -315,6 +343,12 @@ private void doAutoPartition(Instant now, Set<Long>
tableIds, boolean forceDoAut
}
TableInfo tableInfo = autoPartitionTables.get(tableId);
+ if (tableInfo == null) {
+ LOG.info(
+ "Skipping auto partitioning for table id {} as it is
not registered.",
+ tableId);
+ continue;
Review Comment:
The new skip path for stale scheduled tasks is expected during
enable/disable operations, so logging it at INFO may create unnecessary noise
in coordinator logs (especially if multiple stale tasks fire). Consider
lowering this to DEBUG to keep INFO reserved for actionable operational events.
##########
fluss-common/src/main/java/org/apache/fluss/utils/AutoPartitionStrategy.java:
##########
@@ -86,4 +87,46 @@ public int numToRetain() {
public TimeZone timeZone() {
return timeZone;
}
+
+ @Override
+ public String toString() {
+ return "AutoPartitionStrategy{"
+ + "autoPartitionEnable="
+ + autoPartitionEnable
+ + ", key='"
Review Comment:
In `toString()`, the label `autoPartitionEnable` is inconsistent with the
rest of the codebase naming (`isAutoPartitionEnabled`,
`table.auto-partition.enabled`). Renaming the label improves readability of the
Coordinator log that prints old/new strategies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
