charlesdong1991 commented on code in PR #622:
URL: https://github.com/apache/fluss-rust/pull/622#discussion_r3423088166
##########
crates/fluss/src/cluster/mod.rs:
##########
@@ -77,20 +79,23 @@ impl ServerNode {
pub enum ServerType {
TabletServer,
CoordinatorServer,
+ Unknown,
Review Comment:
i think we should update api-reference for this too
##########
crates/fluss/src/cluster/mod.rs:
##########
@@ -77,20 +79,23 @@ impl ServerNode {
pub enum ServerType {
TabletServer,
CoordinatorServer,
+ Unknown,
}
impl ServerType {
pub fn to_type_id(&self) -> i32 {
match self {
ServerType::CoordinatorServer => 1,
ServerType::TabletServer => 2,
+ ServerType::Unknown => -1,
}
}
pub fn from_type_id(type_id: i32) -> Option<ServerType> {
match type_id {
1 => Some(ServerType::CoordinatorServer),
2 => Some(ServerType::TabletServer),
+ -1 => Some(ServerType::Unknown),
Review Comment:
for any unrecognized id, should we return None or Unknown?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
