beryllw commented on code in PR #624:
URL: https://github.com/apache/fluss-rust/pull/624#discussion_r3434812068
##########
crates/fluss-test-cluster/src/lib.rs:
##########
@@ -165,21 +218,32 @@ impl FlussTestingClusterBuilder {
}
}
- fn all_containers_exist(&self) -> bool {
- self.container_names().iter().all(|name| {
- std::process::Command::new("docker")
- .args(["ps", "-q", "--filter", &format!("name=^{}$", name)])
- .output()
- .map(|o| !String::from_utf8_lossy(&o.stdout).trim().is_empty())
- .unwrap_or(false)
- })
+ async fn all_containers_exist(&self) -> bool {
+ let Some(docker) = docker_client().await else {
+ return false;
+ };
+ for name in self.container_names() {
+ // Anchored exact-name match; `all(false)` = running only, so a
stopped
+ // leftover counts as absent and gets recreated.
+ let mut filters = HashMap::new();
+ filters.insert("name".to_string(), vec![format!("^{name}$")]);
+ let options = ListContainersOptionsBuilder::default()
+ .all(false)
+ .filters(&filters)
+ .build();
+ match docker.list_containers(Some(options)).await {
+ Ok(list) if !list.is_empty() => continue,
+ _ => return false,
+ }
+ }
Review Comment:
Sorry for the late reply, +1. I've already addressed it in a follow-up PR
(#627).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
