Jackeyzhe commented on code in PR #3431:
URL: https://github.com/apache/fluss/pull/3431#discussion_r3442781809
##########
fluss-server/src/main/java/org/apache/fluss/server/coordinator/CoordinatorEventProcessor.java:
##########
@@ -756,7 +756,7 @@ private void
processTableRegistrationChange(TableRegistrationChangeEvent event)
// Skip if the table is not yet registered in coordinator context.
// Should not happen in normal cases.
- if (tableId == null) {
+ if (tableId == TableInfo.UNKNOWN_TABLE_ID) {
Review Comment:
I think this still does not cover the incomplete coordinator context case
described in the PR.
After `getTableIdByPath(tablePath)` returns a valid id,
`getTableInfoById(tableId)` may still return null because table path and table
info are stored separately in `CoordinatorContext`. In that case,
`oldTableInfo.getSchemaInfo()` will still throw an NPE.
Could we restore the `oldTableInfo == null` guard and the corresponding
regression test for this case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
