fhan688 commented on PR #3499:
URL: https://github.com/apache/fluss/pull/3499#issuecomment-4752825810

   > @fhan688 Thanks for the pr. LGTM overall. Just one minor comments.
   > 
   > I got warning from my ide
   > 
   > 
'getBoolean(org.apache.flink.configuration.ConfigOption<java.lang.Boolean>)' is 
deprecated 
'getString(org.apache.flink.configuration.ConfigOption<java.lang.String>)' is 
deprecated
   > 
   > Could you please help fix this warning
   
   Thanks for pointing this out. I replaced the deprecated 
`getString(ConfigOption)` / `getBoolean(ConfigOption)` usages with 
`get(ConfigOption)` in `UnifiedHudiTableReader`.
   
     Verified with:
     - `rg "flinkHudiOptions\\.getString|flinkHudiOptions\\.getBoolean"`: no 
remaining matches
     - `mvn -pl fluss-lake/fluss-lake-hudi -am -DskipITs -Dcheckstyle.skip=true 
-DfailIfNoTests=false test`: passed, 68 tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to