gnuhpc commented on PR #630: URL: https://github.com/apache/fluss-rust/pull/630#issuecomment-4754037757
Rebased onto updated #629 and proactively applied the same `proto::*`/`Default` cleanup that the maintainer requested on #629 (https://github.com/apache/fluss-rust/pull/629#pullrequestreview-4533670812): **Domain types added** (`crates/fluss/src/metadata/`): - `kv_snapshot_lease.rs` — `KvSnapshotLeaseForTable` + `KvSnapshotLeaseForBucket` - `producer_offsets.rs` — `ProducerTableOffsets` + `BucketOffset` - Extended `table.rs` — added `to_pb`/`from_pb` to existing `TableBucket` **Wrapper signatures**: 3 wrappers that took raw `proto::Pb*` in `new()` now take domain types (`acquire_kv_snapshot_lease`, `register_producer_offsets`, `release_kv_snapshot_lease`). **`#[derive(Default)]` dropped** on the 17 arg-taking wrappers in this PR (kept on `get_cluster_health` which is param-less, matching the pre-existing `list_databases.rs` precedent). **Not changed** (yet): `scan_kv.rs` retains `Vec<proto::PbScanReqForBucket>` in its `new()` for now. The wrapper has no consumer on this branch (its caller `KvBatchScanner` lands in #633), and making it `pub(crate)` here triggers `cargo clippy --all-targets -- -D warnings` failures from dead-code lints. I'll address it on #633 when the consumer arrives — either by adding a `ScanReqForBucket` domain type or by making the wrapper crate-private once it actually has a use site. cargo build + clippy (`-D warnings`) + 548 unit tests pass locally. Pushed `9d2fbff`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
